Basic e-commerce sitemap support #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: Since sitemap support includes a function to determine through heuristics if a URL is a product details page URL, I felt it made sense to use that function also for an unrelated feature: for
crawl_strategy=automaticto work likecrawl_strategy=direct_itemon matching URLs. While I think that’s how it should be in a world where the heuristics function is quite accurate, the current function is very naive, and I’m not sure how much more we can improve it, so I think it might be better to revert that change. But I thought it was worth discussing first over some code.