Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid HTML escaping in JSON files #3560

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matthias314
Copy link
Contributor

Currently the HTML characters "<" and ">" are escaped in the JSON file micro writes, see here. This makes the bindings.json file hard to read: Instead of

{
    "<F5><a>": "command:log",
}

one gets

{
    "\u003cF5\u003e\u003ca\u003e": "command:log",
}

This PR changes this. I'm assuming that the HTML security concern behind the escaping doesn't apply here. For settings.json I don't have a strong use case. I just thought it's best to use the same code for both files.

internal/config/settings.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants