Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two OpenQASM issues: handle spaces between phases and add U gate. #226

Merged

Conversation

dlyongemallo
Copy link
Contributor

@dlyongemallo dlyongemallo commented May 9, 2024

Also add round-trip tests from pyzx to qiskit back to pyzx using both OpenQASM 2 and 3.

Fixes #225 and #227.

Add round-trip tests from pyzx to qiskit back to pyzx using both OpenQASM 2 and 3.

Fixes zxcalc#225.
@dlyongemallo dlyongemallo changed the title Fix parsing of OpenQASM code with spaces between phase parameters. Fix two OpenQASM issues: handle spaces between phases and add U gate. May 9, 2024
@dlyongemallo dlyongemallo marked this pull request as draft May 9, 2024 06:50
…ASM 3.

Together with zxcalc#218, fixes zxcalc#227.
@dlyongemallo dlyongemallo force-pushed the fix_qasm3_space_between_phases branch from bd8d524 to 4f98629 Compare May 9, 2024 06:53
@dlyongemallo dlyongemallo marked this pull request as ready for review May 9, 2024 06:54
@jvdwetering jvdwetering merged commit 42343c1 into zxcalc:master May 10, 2024
3 checks passed
@dlyongemallo dlyongemallo deleted the fix_qasm3_space_between_phases branch May 12, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qiskit 1.0 OpenQASM 3 output breaks qasmparser because of spaces between phases
2 participants