Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle handler error during initialisation #1440

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

cdjackson
Copy link
Member

If there is an error with the communications during initialisation, but after the version was requested, then the request to get the network parameter returns null, and this causes an NPE which is not handled, and results in no notification higher up the stack. Ultimately this block the initialize method returning.

This checks for null return, then checks if the ASH handler is alive at the end of initialisation. Any error will result in an error return from initialize().

Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@cdjackson cdjackson added the bug label Oct 4, 2024
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@cdjackson cdjackson merged commit 531ee12 into master Oct 5, 2024
4 checks passed
@cdjackson cdjackson deleted the ezsp-init-exception-handling branch October 5, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant