Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScienceDirect: Don't add isDTMRedir URL param #3368

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

AbeJellinek
Copy link
Member

I kept the check for isDTMRedir in getPDFLink() - not sure if that branch ever works anymore, but it seems safer to leave it be. That method should, separately, be overhauled in general, since the click()-based branch no longer works with MV3.

Fixes #3367

@adomasven
Copy link
Member

If we need click() to function in MV3 we can restore it. Just let me know.

@AbeJellinek
Copy link
Member Author

I think we'll be fine without it.

@AbeJellinek AbeJellinek merged commit 56c3b87 into zotero:master Oct 3, 2024
1 check failed
@AbeJellinek AbeJellinek deleted the 3367-sd-pdf-url branch October 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ScienceDirect: isDTMRedir=true is causing failure to download PDF attachments via Zotero captcha viewer
2 participants