Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dalloz, Dalloz Bibliothèque, Lextenso, Vie Publique and Jus Politicum translators. #3301

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

carnetdethese
Copy link

@carnetdethese carnetdethese commented Apr 17, 2024

Adding translators for the Legal databases Dalloz, Dalloz Bibliothèque, Lextenso, Jus Politicum and Vie Publique.

@carnetdethese carnetdethese changed the title Adding Dalloz translator. Adding Dalloz, Dalloz Bibliothèque, Lextenso and Jus Politicum translators. Apr 18, 2024
@carnetdethese carnetdethese changed the title Adding Dalloz, Dalloz Bibliothèque, Lextenso and Jus Politicum translators. Adding Dalloz, Dalloz Bibliothèque, Lextenso, Vie Publique and Jus Politicum translators. Apr 19, 2024
"translatorID": "2ea86ad9-71ca-410c-9126-9d7d98722acf",
"label": "Dalloz Bibliothèque",
"creator": "Alexandre Mimms",
"target": "https?://(?:www[.-])?bibliotheque[.-]lefebvre[.-]dalloz(?:[.-]fr)?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the [.-]s are to support proxies? We don't do that here. Add your proxy to the Zotero Connector and the translator will get correct URLs automatically.

Suggested change
"target": "https?://(?:www[.-])?bibliotheque[.-]lefebvre[.-]dalloz(?:[.-]fr)?",
"target": "https?://(www\\.)?bibliotheque\\.lefebvre\\.dalloz\\.fr",

Dalloz Bibliotheque.js Outdated Show resolved Hide resolved
Dalloz Bibliotheque.js Outdated Show resolved Hide resolved
Dalloz Bibliotheque.js Outdated Show resolved Hide resolved
Dalloz Bibliotheque.js Outdated Show resolved Hide resolved
Vie Publique.js Outdated Show resolved Hide resolved
Vie Publique.js Outdated Show resolved Hide resolved
Vie Publique.js Outdated Show resolved Hide resolved
Vie Publique.js Outdated Show resolved Hide resolved
Vie Publique.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants