Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to close a ballot from accepting new votes #109

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: add ability to close a ballot from accepting new votes #109

wants to merge 12 commits into from

Conversation

zorn
Copy link
Owner

@zorn zorn commented Dec 30, 2024 •
edited
Loading

TODO

Fixes #32
Fixes #112

zorn
zorn commented Jan 1, 2025
View reviewed changes
lib/flick/ranked_voting.ex
ballot
|> change_ballot(attrs)
|> Repo.update()
end

def update_ballot(_ballot, _attrs) do
{:error, :can_not_update_published_ballot}
{:error, :can_only_update_draft_ballots}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be plural if the function accepts a single ballot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@zorn