Add unit tests for ArrayMetadata module.
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the `ext_point` type into a module with minimum functions for serialization and comparison; namely of_yojson, to_yojson and equal.
This also improves the correctness of serializing/deserializing the ArrayMetadata type. it also removes unnecessary functions exposed in the module signature.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
===========================================
+ Coverage 12.92% 29.75% +16.82%
===========================================
Files 9 9
Lines 704 726 +22
===========================================
+ Hits 91 216 +125
+ Misses 613 510 -103 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves the correctness of serializing/deserializing the
ArrayMetadata type. it also removes unnecessary functions exposed in
the module signature.
ext_pointtype into a module with minimumfunctions for serialization and comparison; namely
of_yojson,to_yojsonandequal.