Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement partial encode/decode for sharding codec. #37

Merged
merged 5 commits into from
Jul 19, 2024
Merged

implement partial encode/decode for sharding codec. #37

merged 5 commits into from
Jul 19, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Jul 17, 2024 •
edited
Loading

closes #14

@zoj613 zoj613 added codecs relating to codecs performance relating to performance refactoring labels Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.17225% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.89%. Comparing base (41ff7dd) to head (aa8e5d5).

Files Patch % Lines
lib/codecs/array_to_bytes.ml 97.27% 3 Missing ⚠️
lib/codecs/codecs.ml 75.00% 2 Missing ⚠️
lib/storage/storage.ml 96.42% 2 Missing ⚠️
lib/storage/filesystem.ml 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   94.81%   96.89%   +2.08%     
==========================================
  Files          13       13              
  Lines        1079     1159      +80     
==========================================
+ Hits         1023     1123     +100     
+ Misses         56       36      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 force-pushed the partial_encode branch 7 times, most recently from d32d168 to beb51cd Compare July 19, 2024 19:47
zoj613 added 2 commits July 19, 2024 21:48
@zoj613
Optimize sharding config codec.
a19376f 
This commit uses the store specific partial readers and writers to avoid
reading full bytes of an inner chunk whenever possible.
@zoj613
Remove unused erase_values abstract store function.
aa8e5d5
@zoj613 zoj613 merged commit c2c19da into main Jul 19, 2024
4 checks passed
@zoj613 zoj613 deleted the partial_encode branch July 19, 2024 19:56
@zoj613 zoj613 mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codecs relating to codecs performance relating to performance refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement partial encoding/decoding for the sharding indexed codec.
1 participant
@zoj613