Enforce shard index codec chain invariant #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 95.01% 95.42% +0.40%
==========================================
Files 13 13
Lines 1084 1092 +8
==========================================
+ Hits 1030 1042 +12
+ Misses 54 50 -4 ☔ View full report in Codecov by Sentry. |
The V3 spec insists that the codec chain for a shard index array must not include compression codecs like Gzip since it would make it impractical to calculate index bytes size. This commit ensures this invariant is not violated by making a shard's index codec chain correct by construction. That is, specifying a non-fixed size bytes-to-bytes codec in the `index_codec` field is a compile time error.
zoj613
force-pushed
the
index_codec_invariant
branch
from
d47551d to
8518c7b
Compare
zoj613
changed the title
These are not needed and affect code coverage negatively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15
The V3 spec insists that the codec chain for a shard index array
must not include compression codecs like Gzip since it would make
it impractical to calculate index bytes size. This commit
ensures this invariant is not violated by making a shard's index
codec chain correct by construction. That is, specifying a non-fixed
size bytes-to-bytes codec in the
index_codecfield is a compile timeerror.