Make get_array work with all supported data types.
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Ndarray.set_fancy*` functions unfortunately don't work for array kinds other than Float32, Float64, Complex32 and Complex64. See: owlbarn/owl#671 . As a workaround we manually set each coordinate one-at-time using the basic set function which does not suffer from this bug. It is likely much slower for large Zarr chunks but necessary for usability.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 74.32% 73.75% -0.58%
==========================================
Files 13 13
Lines 1001 1002 +1
==========================================
- Hits 744 739 -5
- Misses 257 263 +6 ☔ View full report in Codecov by Sentry. |
Since GroupNode module no longer references the ArrayNode type, they don't need to be defined in a mutually recursive manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.