Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behaviors): add usb MIDI behavior support #2338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SolidHal
Copy link

adds support for sending MIDI notes across 10 octaves
adds support for sending MIDI control change codes
adds MIDI behavior documentation

docs can be found at docs/docs/behaviors/midi.md

testing:
example implementation on the btrfld keyboard here https://github.com/SolidHal/zmk/tree/btrfld/app/boards/shields/btrfld
tested on both nice_nano_v2 and bluemicro840_v1
verified MIDI output using midisnoop https://linuxaudio.github.io/libremusicproduction/html/tools/midisnoop.html
made a song using this :)

@SolidHal SolidHal requested a review from a team as a code owner June 18, 2024 03:16
@SolidHal SolidHal force-pushed the midi_to_upstream branch 5 times, most recently from 1009573 to 9a36767 Compare June 18, 2024 03:51
adds support for sending MIDI notes across 10 octaves
adds support for sending MIDI control change codes
adds MIDI behavior documentation
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR! I've actually been considering MIDI for a silly side project of mine, so it's wonderful timing to set this hit!

Do you have any interest in trying to also get the BLE bits working based on https://midi.org/midi-over-bluetooth-low-energy-ble-midi ?

Will take me a bit to get to a thorough review of this, but super grateful for the PR!

@caksoylar caksoylar added the core Core functionality/behavior of ZMK label Jun 18, 2024
@SolidHal
Copy link
Author

@petejohanson glad to hear. i'm hoping this means more people make weird, cool instruments :)

Do you have any interest in trying to also get the BLE bits working based on https://midi.org/midi-over-bluetooth-low-energy-ble-midi ?

perhaps in the future, but not right now. :)

@joelspadin
Copy link
Collaborator

FYI, there's now work in progress to add a USB MIDI driver to Zephyr at zephyrproject-rtos/zephyr#81197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core functionality/behavior of ZMK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants