Feat/add more test cases for body parsing #70
Conversation
wshino
changed the title
| @@ -73,6 +73,126 @@ contract EmailAccountRecoveryTest_handleRecovery is StructHelper { | |||
| ); | |||
| } | |||
|
|
|||
| function testExpectRevertHandleRecoveryInvalidRecoveredAccount() public { | |||
There was a problem hiding this comment.
What is the difference between testExpectRevertHandleRecoveryInvalidRecoveredAccount and testExpectRevertHandleRecoveryInvalidAccountInEmail?
There was a problem hiding this comment.
@JohnGuilding The first test is more focused on the initial invalid account scenario without any prior state changes.
The second test ensures that even after a guardian is accepted, the function still correctly handles an invalid account scenario.
| ); | ||
| } | ||
|
|
||
| // function testRequestGuardianNotOwner() public { |
| // Upgrade to new implementation through proxy | ||
| emailAuthProxy.upgradeToAndCall( | ||
| address(newImplementation), | ||
| new bytes(0) |
There was a problem hiding this comment.
Should we encode a call here and assert something about the new state as well as the old state?
There was a problem hiding this comment.
@JohnGuilding emailAuthProxy has already initialized once, should I create a new implementation for testing only?
|
Also @wshino we don't have tests for (correct me if I'm wrong):
Could we add these as well? |
Add test cases for:
Please let me know if there are any test cases which should be needed.