Draft changes to support modular accounts #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGuilding
commented
Jun 7, 2024
| @@ -16,6 +16,9 @@ abstract contract EmailAccountRecovery { | |||
| address public dkimAddr; | |||
| address public emailAuthImplementationAddr; | |||
|
|
|||
| mapping(address account => string[][]) public acceptanceSubjectTemplates; | |||
There was a problem hiding this comment.
These could also be stored in a registry. See zkemail/email-recovery#3
Need to think about how these are stored a bit more.
JohnGuilding
commented
Jun 7, 2024
| @@ -71,8 +76,7 @@ abstract contract EmailAccountRecovery { | |||
|
|
|||
| /// @notice Completes the recovery process. | |||
| /// @dev This function must be implemented by inheriting contracts to finalize the recovery process. | |||
| function completeRecovery() external virtual; | |||
|
|
|||
| function completeRecovery(address account, bytes memory recoveryCalldata) external virtual; | |||
There was a problem hiding this comment.
Haven't got the calldata construction in solidity working yet. Will aim to remove the recoveryCalldata arg if possible (currently unsure if it is possible). Should have an update on this over the weekend
|
Resolved by #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to showcase proposed changes to
EmailAccountRecovery