Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zkfriendly/zk 1053 swap modal prover in email tx builder with gpu prover #102

Conversation

zkfriendly
Copy link
Contributor

Description

This PR integrates GPU-based proving API call and updates the prover configuration structure. The main changes include:

  1. Updated dependencies:

    • Switched to GPU-enabled branch of relayer-utils - will switch to main branch once merged with main
  2. Enhanced prover configuration:

    • Replaced single prover_url with comprehensive ProverConfig struct
    • Added new configuration fields for blueprint ID, zkey downloads, and API key
  3. Updated proving mechanism:

    • Switched from generate_proof to generate_proof_gpu
    • Adjusted new parameter passing for GPU-based proving
  4. Documentation updates:

    • Added blueprint ID and download URLs to circuits README
    • Updated configuration documentation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zkfriendly zkfriendly requested a review from Bisht13 January 4, 2025 12:39
@Bisht13 Bisht13 merged commit 9f1486a into main Jan 6, 2025
5 of 7 checks passed
@Bisht13 Bisht13 deleted the zkfriendly/zk-1053-swap-modal-prover-in-email-tx-builder-with-gpu-prover branch January 6, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants