Fix Unsafe ABI Encoding.

zkemail · Apr 28, 2024 · a07122a · a07122a
1 parent c8f59bc
commit a07122a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/packages/contracts/test/helpers/DeploymentHelper.sol b/packages/contracts/test/helpers/DeploymentHelper.sol
@@ -81,12 +81,14 @@ contract DeploymentHelper is Test {
         SimpleWallet simpleWalletImpl = new SimpleWallet();
         ERC1967Proxy simpleWalletProxy = new ERC1967Proxy(
             address(simpleWalletImpl),
-            abi.encodeWithSelector(
-                simpleWalletImpl.initialize.selector,
-                signer,
-                address(verifier),
-                address(dkim),
-                address(emailAuthImpl)
+            abi.encodeCall(
+                simpleWalletImpl.initialize,
+                (
+                    signer,
+                    address(verifier),
+                    address(dkim),
+                    address(emailAuthImpl)
+                )
             )
         );
         simpleWallet = SimpleWallet(payable(address(simpleWalletProxy)));

diff --git a/packages/contracts/test/helpers/StructHelper.sol b/packages/contracts/test/helpers/StructHelper.sol
@@ -34,11 +34,8 @@ contract StructHelper is DeploymentHelper {
 
         vm.mockCall(
             address(verifier),
-            abi.encodeWithSelector(
-                Verifier.verifyEmailProof.selector,
-                emailProof
-            ),
+            abi.encodeCall(Verifier.verifyEmailProof, (emailProof)),
             abi.encode(true)
         );
     }
-}
+}