Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

创建首页V2 代码脚手架 #1522

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

创建首页V2 代码脚手架 #1522

wants to merge 3 commits into from

Conversation

siuze
Copy link
Contributor

@siuze siuze commented Aug 24, 2022

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

siuze added 2 commits August 24, 2022 22:44
@ztl8702 ztl8702 requested a review from rovinglight September 7, 2022 12:33
@ztl8702
Copy link
Collaborator

ztl8702 commented Sep 11, 2022

@rovinglight 审核。任务背景:#1520

Copy link
Contributor

@rovinglight rovinglight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js/packages/miniapp/src/assets/background.png 这个图片文件好像已经进行过尺寸裁剪了,但建议再进行如下几步处理:

  1. 裁剪掉顶部透明部分,或者直接用 CSS 隐藏起来。
  2. 将图片转换为 JPG 格式。因为相比于 PNG,JPG 的文件体积总是要小很多,只不过无法记录透明像素。
  3. 压缩一下,转换以及压缩都可以用 Squoosh 来进行。

这张图片处理过后应该可以减少 95% 左右的文件大小,最终可能在 10kb 左右。

Comment on lines +35 to +37
padding-left: 50rpx;
padding-right: 50rpx;
border-radius: 20rpx;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接写 px 即可,编译时 Taro 会将其转换成 rpx 的。

@rovinglight
Copy link
Contributor

Thanks,其他部分看起来没问题。抱歉 review 拖得有点久~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants