add unit test and remove unused code #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huanghaoyuanhhy Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
huanghaoyuanhhy
force-pushed
the
add-ut
branch
from
1b0f63f to
7252e8b
Compare
|
/kind improvement |
sre-ci-robot
added
the
kind/improvement
huanghaoyuanhhy
force-pushed
the
add-ut
branch
3 times, most recently
from
65ec8d8 to
1d70c2e
Compare
|
/cc @zhuwenxing |
huanghaoyuanhhy
force-pushed
the
add-ut
branch
2 times, most recently
from
c84c256 to
afa4e93
Compare
Signed-off-by: huanghaoyuanhhy <haoyuan.huang@zilliz.com>
huanghaoyuanhhy
force-pushed
the
add-ut
branch
from
afa4e93 to
1e8efb3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huanghaoyuanhhy, Thomas-HuWei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.