Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify docker file typo and fix milvus-backup path in ENTRYPOINT #240

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Nanjangpan
Copy link
Contributor

@Nanjangpan Nanjangpan commented Nov 15, 2023

/kind bug fix

fix #125

  • Correct lowercase letters in the "From" section to capital letters
  • Fix milvus-backup path in ENTRYPOINT

Signed-off-by: jinwoo.baek <jinwoo.baek@linecorp.com>
@sre-ci-robot
Copy link
Collaborator

@Nanjangpan: The label(s) kind/bug, kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug fix
fix #125

  • Correct lowercase letters in the "From" section to capital letters
  • �Fix milvus-backup path in ENTRYPOINT

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link
Collaborator

Welcome @Nanjangpan! It looks like this is your first PR to zilliztech/milvus-backup 🎉

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nanjangpan, zhuwenxing

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhuwenxing zhuwenxing merged commit 623bed0 into zilliztech:main Nov 28, 2023
16 checks passed
zhuwenxing pushed a commit to zhuwenxing/milvus-backup that referenced this pull request Dec 20, 2023
…lliztech#240)

Signed-off-by: jinwoo.baek <jinwoo.baek@linecorp.com>
Co-authored-by: jinwoo.baek <jinwoo.baek@linecorp.com>
zhuwenxing pushed a commit to zhuwenxing/milvus-backup that referenced this pull request Feb 21, 2024
…lliztech#240)

Signed-off-by: jinwoo.baek <jinwoo.baek@linecorp.com>
Co-authored-by: jinwoo.baek <jinwoo.baek@linecorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]The docker container can not run with the default dockerfile
3 participants