Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support parameters that appear in more than one parameter group #4

Open
fizzAI opened this issue Feb 17, 2025 · 1 comment
Open

Comments

@fizzAI
Copy link

fizzAI commented Feb 17, 2025

If you try to use APOLLO to train, for example, Llama 3 1b, which has tied embeddings (IE the embed_tokens and lm_head layers use the same underlying parameters), it fails to load the optimizer with
ValueError: some parameters appear in more than one parameter group
For now you can just manually exclude the embedding layers from the optimizer, but it would be nice if it worked properly ootb :3

@zhuhanqing
Copy link
Owner

Hi @fizzAI , thank you so much for your suggestion!
We will work on your request and get back to u soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants