Customer verify request + other updates #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
August 26, 2020 20:33
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==============================================
- Coverage 100.00% 83.64% -16.36%
- Complexity 145 186 +41
==============================================
Files 45 51 +6
Lines 426 532 +106
==============================================
+ Hits 426 445 +19
- Misses 0 87 +87
Continue to review full report at Codecov.
|
|
You've made a lot of these changes strval ($ transactionId) => (string) $ transactionId. Why? |
|
It has better speed performance and decrease cognitive loading. Decreased
parenthesis nesting.
пт, 28 авг. 2020 г., 08:57 Roman Zhuravel <notifications@github.com>:
… You've made a lot of these changes strval ($ transactionId) => (string) $
transactionId. Why?
Pay attention to Codecov Report
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APYUDZX7FXASKVFBTX7O7DLSC5BNJANCNFSM4QMYXGZA>
.
|
|
So what? |
Conflicts |
|
Merged |
added 2 commits
September 10, 2020 12:34
…-php-client into customer-verify-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use;strval()to(string)typecasting to decrease cognitive loading and improve speed performance;$response->get()to be able to get response as array with default value$response->get(null, []);