Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable homebrew install checks #47

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: disable homebrew install checks #47

merged 2 commits into from
Nov 19, 2024

Conversation

isabelroses
Copy link
Contributor

closes #45

zhaofengli
zhaofengli approved these changes Nov 19, 2024
View reviewed changes
Copy link
Owner

@zhaofengli zhaofengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhaofengli zhaofengli merged commit 5eb00c5 into zhaofengli:main Nov 19, 2024
1 check passed
@isabelroses isabelroses deleted the patch-1 branch November 20, 2024 08:08
zhaofengli added a commit that referenced this pull request Nov 20, 2024
@zhaofengli
Only set INSTALLING_HOMEBREW if homebrew module is enabled
333d5b2 
Fallout of #47.

Fixes #48.
This was referenced Nov 20, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaofengli zhaofengli zhaofengli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New nix-darwin check prevents the "nix-homebrew performs brew installation" use case from working
2 participants
@isabelroses @zhaofengli