fix: duplicate addresses

[fadeev]

• removed duplicate addresses
• removed Mumbai

[fadeev]

@brewmaster012 @lumtis please, review. Need a second review.

[skosito]

just 2 small comments

[skosito]

just to double check if this change is needed since its not mentioned in description?

[fadeev]

When I try to remove it,

yarn

! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing yarn@1.22.21+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72.

For some reason even on older node versions Corepack decides to set the package manager explicitly. I've changed this to yarn@1.22.21: 4454170

[skosito]

this doesnt look like a duplicate in this file, just to double check, or is it handled by this:

addresses.push({
          address: factoryAddress,
          category: "messaging",
          chain_id: router.chain_id,
          chain_name: router.chain_name,
          type: "uniswapV2Factory",
        });

[fadeev]

In main we have two identical entries:

protocol-contracts/data/addresses.mainnet.json

Lines 37 to 50 in 44edae0

	{
	"address": "0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f",
	"category": "messaging",
	"chain_id": 1,
	"chain_name": "eth_mainnet",
	"type": "uniswapV2Factory"
	},
	{
	"address": "0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f",
	"category": "messaging",
	"chain_id": 1,
	"chain_name": "eth_mainnet",
	"type": "uniswapV2Factory"
	},

This PR leaves just one:

protocol-contracts/data/addresses.mainnet.json

Lines 37 to 43 in a0e7a4b

	{
	"address": "0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f",
	"category": "messaging",
	"chain_id": 1,
	"chain_name": "eth_mainnet",
	"type": "uniswapV2Factory"
	},

This is handled by the script, so I've removed the entry from tasks/addresses.ts to avoid having duplicate entries.

[lumtis]

@fadeev I solved the conflict in package.json here since it was just about removing a comma but it seems generate files is failing now, do you know the reason?

[skosito]

@fadeev I solved the conflict in package.json here since it was just about removing a comma but it seems generate files is failing now, do you know the reason?

it seems that one of those 2 is not iterable and spread operator is used on them, i can also check:

 const networks = [...mainnet, ...testnet];

also maybe related to yarn version change there is duplicate entry in package.json, will remove it

EDIT: this did the trick, approving PR again