Skip to content

Commit

Permalink
More reverting of dumb PR
Browse files Browse the repository at this point in the history
  • Loading branch information
@adamierymenko
adamierymenko committed Sep 23, 2021
1 parent 375e5ee commit 19f3a97
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions ext/bin/tap-windows-ndis6/x64.old/zttap300.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ DriverVer=08/13/2015,6.2.9200.20557

[Strings]
DeviceDescription = "ZeroTier One Virtual Port"
Provider = "ZeroTier Networks LLC"
Provider = "ZeroTier Networks LLC" ; We're ZeroTier, Inc. now but kernel mode certs are $300+ so fuqdat.

This comment has been minimized.

Sign in to view

Copy link
@rebroad

rebroad Sep 26, 2021

what is going on?!

This comment has been minimized.

Sign in to view

Copy link
@adamierymenko

adamierymenko Sep 27, 2021

Author Contributor

Hey, sorry for the frustrated comments there. The problem is that anything that changes a single byte of the Windows drivers breaks Windows completely. Any change to Windows drivers requires that they be not only re-bulit but re-notarizred by Microsoft, and the Microsoft notarization process is an unbelievably painful manual ordeal. That's why the Windows drivers are minimal and almost never change. In the long term I have some ideas about getting away from shipping our own drivers on Windows just like we have on MacOS.

This comment has been minimized.

Sign in to view

Copy link
@adamierymenko

adamierymenko Sep 27, 2021

Author Contributor

Those comments in the INI are a bit unprofessional, but changing them is so painful we don't want to do so until we have more things to change in the driver. We might do it when we get to building an AARCH64 driver for Windows, or as I said we may obsolete these drivers completely.

; To build for x86, take NTamd64 off this and off the named section manually, build, then put it back!
[Manufacturer]
Expand Down Expand Up @@ -70,7 +70,7 @@ AddService = zttap300, 2, zttap300.service

[zttap300.reg]
HKR, Ndi, Service, 0, "zttap300"
HKR, Ndi\Interfaces, UpperRange, 0, "ndis5" ; 'ndis5' is correct
HKR, Ndi\Interfaces, UpperRange, 0, "ndis5" ; yes, 'ndis5' is correct... yup, Windows.
HKR, Ndi\Interfaces, LowerRange, 0, "ethernet"
HKR, , Manufacturer, 0, "%Provider%"
HKR, , ProductName, 0, "%DeviceDescription%"
Expand Down
4 changes: 2 additions & 2 deletions ext/bin/tap-windows-ndis6/x86.old/zttap300.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ DriverVer=08/13/2015,6.2.9200.20557

[Strings]
DeviceDescription = "ZeroTier One Virtual Port"
Provider = "ZeroTier Networks LLC"
Provider = "ZeroTier Networks LLC" ; We're ZeroTier, Inc. now but kernel mode certs are $300+ so fuqdat.

; To build for x86, take NTamd64 off this and off the named section manually, build, then put it back!
[Manufacturer]
Expand Down Expand Up @@ -70,7 +70,7 @@ AddService = zttap300, 2, zttap300.service

[zttap300.reg]
HKR, Ndi, Service, 0, "zttap300"
HKR, Ndi\Interfaces, UpperRange, 0, "ndis5" ; 'ndis5' is correct
HKR, Ndi\Interfaces, UpperRange, 0, "ndis5" ; yes, 'ndis5' is correct... yup, Windows.
HKR, Ndi\Interfaces, LowerRange, 0, "ethernet"
HKR, , Manufacturer, 0, "%Provider%"
HKR, , ProductName, 0, "%DeviceDescription%"
Expand Down
2 changes: 1 addition & 1 deletion ext/bin/tap-windows-ndis6/x86/zttap300.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ AddService = zttap300, 2, zttap300.service

[zttap300.reg]
HKR, Ndi, Service, 0, "zttap300"
HKR, Ndi\Interfaces, UpperRange, 0, "ndis5" ; 'ndis5' is correct
HKR, Ndi\Interfaces, UpperRange, 0, "ndis5" ; yes, 'ndis5' is correct... yup, Windows.
HKR, Ndi\Interfaces, LowerRange, 0, "ethernet"
HKR, , Manufacturer, 0, "%Provider%"
HKR, , ProductName, 0, "%DeviceDescription%"
Expand Down

0 comments on commit 19f3a97

Please sign in to comment.