Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updates #28

wants to merge 4 commits into from

Conversation

gyepisam
Copy link

@gyepisam gyepisam commented Jan 2, 2025

This PR contains:

  1. Update to a test file to match current behavior.
  2. Bug fix to allow '.pull' command argument filenames to start with '@'.
  3. New feature to allow the output filename to be specified. This change increments the version number.
  4. Update to README file: Increment version number and replace the unmaintained Changelog section with a reference to see the git log.

@gyepisam
Update test output
9933b6b 
Problem: Code fences are now generated, but are not in test output file.
Solution: Regenerate file.
@gyepisam
Restrict chunk regex for pull file
f4e50fd 
Problem: The regex for matching a file chunk
in the '.pull' command matched filenames
that begin with '@'.  Such files names are used
in the redo build system.

Solution: Restrict the regex to match at least one filename character.
@gyepisam
Parameterize output filename
b7139ff 
Problem: Output filename is constructed from input filename.
In addition to reducing flexibility, the output file is destroyed
in the event of an error.

Solution: Add the ability to, optionally, specify the output filename as
a second argument.  While the file destruction problem is not directly addressed,
that problem can now be solved externally to gitdown.
@gyepisam
Update README
650d207 
Updated version number.
Replaced Changelog section with a reference to git log.
Regenerated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gyepisam