[TableGen] Implement basic parser #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is an initial implementation of a parser and PSI for TableGen within IntelliJ. It is already capable of parsing all MLIR TableGen files that I tested it against and build and accurate AST useful for e.g. syntax highlighting. The reason for implementing this rather than enhancing the LSP is mainly the difficulty of pushing some of these changes upstream, especially as the datastructures are optimized for fast and low-memory compilation, not IDE-like use-cases. The parser does currently not have good error recovery which is left to future PRs. Tests are not 100% complete either.
Qodana Community for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.3.4
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial implementation of a parser and PSI for TableGen within IntelliJ. It is already capable of parsing all MLIR TableGen files that I tested it against and build and accurate AST useful for e.g. syntax highlighting.
The reason for implementing this rather than enhancing the LSP is mainly the difficulty of pushing some of these changes upstream, especially as the datastructures are optimized for fast and low-memory compilation, not IDE-like use-cases.
The parser does currently not have good error recovery which is left to future PRs. Tests are not 100% complete either.