Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/typings support #352

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Feat/typings support #352

wants to merge 6 commits into from

Conversation

JuanjoSalvador
Copy link
Contributor

Improvements on styling.

  • Replace camelCase with snake_case
  • Add type for input paramenters
  • Add return type for each function
  • Move BlogEntry class to its own file

@JuanjoSalvador
feat(renderer): Add types for input parameter and return types
c446fe1 
Each function needs to has input parameters type defined, so Python can detect them and avoid unmanaged errors. Also helps to maintain the code.
@JuanjoSalvador
feat(blog_entry): BlogEntry must be its own class.
74d6d33 
Avoid declaring more than one class into the same file.
@JuanjoSalvador
style(snake_case): Rename settings from camelCase to snake_case.
e603df1 
According to Python guidelines.
@JuanjoSalvador
fix(settings): Replace format strings with f-strings
717fd5c
@JuanjoSalvador
feat(app): Typings for BlaskApp module
85e8d1b
@JuanjoSalvador
chore(blask): Rename modules with snake_case names
371f3d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JuanjoSalvador