Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twister: runner: Log trace on general exception #85204

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

golowanow
Copy link
Member

@golowanow golowanow commented Feb 5, 2025

Log trace on general exception at ProjectBuilder to provide more details on its cause instead of just

ERROR   - General exception: [Errno 32] Broken pipe

https://github.com/zephyrproject-rtos/zephyr/actions/runs/13095023661/job/36536311689#step:13:5834

See discussion on Discord

Log trace on general exception at ProjectBuilder to provide
more details on its cause.

Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
@golowanow golowanow marked this pull request as ready for review February 5, 2025 07:41
@zephyrbot zephyrbot added area: Twister Twister size: XS A PR changing only a single line of code labels Feb 5, 2025
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PerMac
Copy link
Member

PerMac commented Feb 5, 2025

@nashif do you think modifying the workflow to also try doing the reporting stage makes sense? Now twister can crash after 20h and all the already executed statuses are lost.

@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Feb 5, 2025
@nashif
Copy link
Member

nashif commented Feb 5, 2025

@nashif do you think modifying the workflow to also try doing the reporting stage makes sense? Now twister can crash after 20h and all the already executed statuses are lost.

thw workflow already tries to upload results, but in the case of an early abort due to a crash, no twister reports are being generated. So when we crash, beside the detailed traceback we need to look into a clean abort with reports.

@kartben kartben merged commit e9cb2ef into zephyrproject-rtos:main Feb 5, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Twister Twister size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants