tests: kernel/msgq_api: add k_thread_join after k_thread_abort #83834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
nashif,
npitre,
peter-mitsis and
TaiJuWu
|
It might be safer to call |
|
I don't think that's going to work. AFAIK, the "after" function is set at the test suite level and it works for all tests. Since not all tests are creating additional threads, it is possible that the thread struct has never been initialized before the function is called. The struct may even contain random data (if in noinit section) and |
|
@dcpleung - you could use an array of I've used that approach a fair bit and it works well. |
On SMP systems, threads going through k_thread_abort() may still be running while the test moves on to the next one. This creates some interferences and may result in the next test failing. So after each test, we need to do k_thread_join() on those threads to make sure they are no longer active. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
dcpleung
force-pushed
the
tests/msgq_api_thread_join
branch
from
6f8bb1a to
54d11e2
Compare
peter-mitsis
approved these changes
Jan 22, 2025
nashif
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SMP systems, threads going through k_thread_abort() may still be running while the test moves on to the next one. This creates some interferences and may result in the next test failing. So add k_thread_join() after k_thread_abort() to make sure those threads have stopped before moving on.