drivers: entropy: add maxq10xx #83797
Open
+421
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ceolin,
galak,
MaureenHelm,
microbuilder,
ozersa,
tomi-font and
ttmut
maass-hamburg
force-pushed
the
add_maxq10xx_entropy
branch
from
b9671de to
25990c8
Compare
|
This looks weird to me. IMHO, the MAXQ10xx is a multi function device, not just a random number generator. Therefore, it should be implemented as such. |
maass-hamburg
force-pushed
the
add_maxq10xx_entropy
branch
from
25990c8 to
77902a6
Compare
add maxq10xx entropy device. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
add maxq10xx mfd device to tests Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
add_maxq10xx_entropy
branch
from
77902a6 to
73387de
Compare
Agreed, maxq10xx family is secure authenticator that supports multiple function, the implementation of them shall not be restrict it for TRNG. I think there might be a new driver class folder like: "drivers/auth" for authenticator OR existing crypto driver interface be extended then used as crypto device. |
|
@ozersa I already changed it to mfd. so that the crypto or auth driver can be added later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add maxq10xx entropy device.