Obex enablement #83781
Open
Obex enablement #83781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Controller
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
carlescufi,
cvinayak,
erbr-ot,
hermabe,
jhedberg,
mtpr-ot,
rugeGerritsen,
sjanc,
Thalley,
theob-pro,
thoh-ot and
wopu-ot
|
Another massive PR? :) @lylezhu2012 I think the L2CAP and RFCOMM improvements could at least be split out into their own PRs. That way I think we can make faster progress with getting functionality merged incrementally. |
Actually, my PR only implements basic goep/obex operations, but goep and obex define too many concepts.
Well, I will remove all other layers changes from this PR. And make small PR for these changes. |
lylezhu2012
force-pushed
the
obex_enablement
branch
4 times, most recently
from
1dfaefe to
e4a2256
Compare
lylezhu2012
force-pushed
the
obex_enablement
branch
from
e4a2256 to
f70741b
Compare
|
test failure is unrelated and will be fixed with #83907 |
makeshi
reviewed
Jan 14, 2025
| @@ -0,0 +1,1443 @@ | |||
| /* obex.h - IrDA Oject Exchange Protocol handling */ | |||
There was a problem hiding this comment.
IrDA suppose should be bluetooth?
There was a problem hiding this comment.
The full name of obex is IrDA Object Exchange Protocol.
makeshi
reviewed
Jan 14, 2025
| #include <errno.h> | ||
| #include <stdbool.h> | ||
|
|
||
| #ifndef ZEPHYR_INCLUDE_BLUETOOTH_OBEX_H_ |
There was a problem hiding this comment.
Generally, the header guard should be placed at the very beginning of the header file, it should be before #include
makeshi
reviewed
Jan 14, 2025
|
|
||
| /** Converts a OBEX response code to string. | ||
| * | ||
| * @return The string representation of the response code code. |
| }; | ||
|
|
||
| /** Converts a OBEX response code to string. | ||
| * |
lylezhu2012
force-pushed
the
obex_enablement
branch
from
f70741b to
59ac793
Compare
lylezhu2012
force-pushed
the
obex_enablement
branch
from
59ac793 to
4c7feba
Compare
In the function `bt_l2cap_br_server_register()`, the PSM cannot be dynamic allocated. And only pre-set PSM is supported. Improve the function `bt_l2cap_br_server_register()` to support the dynamic PSM allocation if the passed PSM is zero. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
In the function `bt_rfcomm_server_register()`, the channel cannot be dynamic allocated. And only pre-set channel is supported. Improve the function `bt_rfcomm_server_register()` to support the dynamic channel allocation if the passed channel is zero. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
In current implementation, the `accept` cannot be identified if the same one `accept` callback is passed by the upper layer. Similar with `accept` of `bt_l2cap_server.accept`, add a parameter `server` to the `bt_rfcomm_server.accept` callback. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Since a new argument `server` is added by `bt_rfcomm_server.accept`, add a argument `server` to function rfcomm_accept() to avoid building issue. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Since a new argument `server` is added by `bt_rfcomm_server.accept`, add a argument `server` to function rfcomm_accept() to avoid building issue. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Add a Kconfig BT_GOEP to control the GOEP feature. Implement the GOEP protocol and transport, both for GOEP 1.1 and GOEP 2.x. For GOEP transport, OBEX over RFCOMM, and OBEX over L2CAP are supported. For GOEP protocol, `put`, `get`, `abort`, `setpath`, and `action` are supported. And only one operation can be processed at the same time. The feature `Reliable Session` is unsupported. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
The MTU of the GOEP should be not less than 255. So, if the transport is RFCOMM, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 264. It includes, - 255 bytes for the minimum MTU of GOEP, - 4 bytes for L2CAP Header, - 5 bytes for RFCOMM header and FCS. And if the transport is L2CAP, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 259. It includes, - 255 bytes for the minimum MTU of GOEP, - 4 bytes for L2CAP Header. Add Kconfig `BT_GOEP_RFCOMM_MTU` to configure the maximum size for RFCOMM transport. The range of `BT_GOEP_RFCOMM_MTU` is `[264, BT_RFCOMM_L2CAP_MTU]`. And the GOEP MTU via RFCOMM transport should be in the range `[255, (BT_GOEP_RFCOMM_MTU-9)]`. Add Kconfig `BT_GOEP_L2CAP_MTU` to configure the maximum size for L2CAP transport. The range of `BT_GOEP_L2CAP_MTU` is `[259, BT_BUF_ACL_RX_SIZE]`. And the GOEP MTU via L2CAP transport should be in the range `[255, (BT_GOEP_L2CAP_MTU-4)]`. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
The buffer `BT_RFCOMM_BUF_SIZE` is used to define the TX buffer size of TX pool. In current implementation, the TX buffer size of RFCOMM cannot be calculated due to the macro `BT_RFCOMM_BUF_SIZE` is defined in internal header file `rfcomm_internal.h`. Move the macro `BT_RFCOMM_BUF_SIZE` form internal header file `rfcomm_internal.h` to interface `rfcomm.h`. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Add commands for GOEP to test transport features. Add commands for transport over RFCOMM, including `register-rfcomm`, `connect-rfcomm`, and `disconnect-rfcomm`. Add commands for transport over L2CAP, including `register-l2cap`, `connect-l2cap`, and `disconnect-l2cap`. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Add commands for GOEP to test OBEX features. Add command `alloc-buf` and `release-buf` to allocate and release TX buffer. Add command set `add-header` to add the OBEX headers to allocated TX buffer. Add command set `client` to send OBEX client requests with allocated TX buffer. Add command set `server` to send OBEX responses with allocated TX buffer. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
There are types of string can be added by using OBEX adding header function bt_obex_add_header_*(). One is byte sequence. Another is null terminated Unicode text. Add a function bt_obex_string_is_valid() to check if the added string is valid. And add a function bt_obex_unicode_is_valid() dedicated to check Unicode string. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
lylezhu2012
force-pushed
the
obex_enablement
branch
from
4c7feba to
2177c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Kconfig BT_GOEP to control the GOEP feature.
Implement the GOEP protocol and transport, both for GOEP 1.1 and GOEP 2.x.
For GOEP transport, OBEX over RFCOMM, and OBEX over L2CAP are supported.
For GOEP protocol,
put,get,abort,setpath, andactionare supported. And only one operation can be processed at the same time. The featureReliable Sessionis unsupported.The MTU of the GOEP should be not less than 255. So, if the transport is RFCOMM, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 264.
It includes,
And if the transport is L2CAP, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 259.
It includes,
Add Kconfig
BT_GOEP_RFCOMM_MTUto configure the maximum size for RFCOMM transport. The range ofBT_GOEP_RFCOMM_MTUis[264, BT_RFCOMM_L2CAP_MTU]. And the GOEP MTU via RFCOMM transport should be in the range[255, (BT_GOEP_RFCOMM_MTU-9)].Add Kconfig
BT_GOEP_L2CAP_MTUto configure the maximum size for L2CAP transport. The range ofBT_GOEP_L2CAP_MTUis[259, BT_BUF_ACL_RX_SIZE]. And the GOEP MTU via L2CAP transport should be in the range[255, (BT_GOEP_L2CAP_MTU-4)].Add commands for GOEP to test transport features.
Add commands for transport over RFCOMM, including
register-rfcomm,connect-rfcomm, anddisconnect-rfcomm.Add commands for transport over L2CAP, including
register-l2cap,connect-l2cap, anddisconnect-l2cap.Add commands for GOEP to test OBEX features.
Add command
alloc-bufandrelease-bufto allocate and release TX buffer.Add command set
add-headerto add the OBEX headers to allocated TX buffer.Add command set
clientto send OBEX client requests with allocated TX buffer.Add command set
serverto send OBEX responses with allocated TX buffer.There are types of string can be added by using OBEX adding header function bt_obex_add_header_*(). One is byte sequence. Another is null terminated Unicode text.
Add a function bt_obex_string_is_valid() to check if the added string is valid. And add a function bt_obex_unicode_is_valid() dedicated to check Unicode string.