Add CAN driver support for Renesas RZ/G3S #83778
Conversation
Update commit id for hal_renesas Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add CAN driver support for Renesas RZ/G3S Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add CAN nodes to Renesas RZ/G3S devicetree Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add CAN support for board RZ/G3S-SMARC Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
zephyrbot
requested review from
alexanderwachter,
henrikbrixandersen,
martinjaeger,
str4t0m and
tgorochowik
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_renesas
DNM
tests/drivers/can/api/src/canfd.c
Outdated
| @@ -527,7 +527,11 @@ ZTEST_USER(canfd, test_set_timing_data_while_started) | |||
| struct can_timing timing = { 0 }; | |||
| int err; | |||
|
|
|||
| #ifdef CONFIG_CAN_RENESAS_RZ_CANFD | |||
There was a problem hiding this comment.
No SoC/driver/board specific #ifdefs in generic API tests, please. You need to find another solution.
There was a problem hiding this comment.
Understood. I have reverted the change. Unfortunately, RZ/G3S cannot calculate the sample point of 87.5% accurately, so the test_set_timing_data_while_started fail. Is it acceptable if we change the err check at line 531 to range check as below (in fact, 25 is enough for us)
zassert_between_inclusive(err, 0, 50, "failed to calculate data timing (err %d)", err);
There was a problem hiding this comment.
@henrikbrixandersen , could you please confirm my above solution. Thanks
Add test support for CAN driver of RZ/G3S-SMARC Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
nhutnguyenkc
force-pushed
the
rzg3s_support_can
branch
from
b37f36e to
ac70044
Compare
Add CAN driver support for Renesas RZ/G3S.
Since RZ/G3S does not support to calculate perfectly the sample point of 87,5%, so the test update is required.
Need: zephyrproject-rtos/hal_renesas#65