dts: bindings: counter: Change the property names in the overlay #83770
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
zephyrbot
requested review from
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
nordic-krch
decsny
previously approved these changes
Jan 10, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
rruuaanng
force-pushed
the
dts-style-counter
branch
from
b2fe9fc to
63dd330
Compare
rruuaanng
changed the title
Rename the following properties in binding and overlay: -- primary_source => primary-source -- secondary_source => secondary-source -- filter_count => filter-count -- filter_period => filter-period Signed-off-by: James Roy <rruuaanng@outlook.com>
rruuaanng
force-pushed
the
dts-style-counter
branch
from
63dd330 to
6c4eacf
Compare
fabiobaltieri
previously approved these changes
Jan 13, 2025
kartben
reviewed
Jan 13, 2025
Rename the primary_source, secondary_source, filter_count and filter_period property to primary-source, secondary-source, filter-count and filter-period in the devicetree and bindings of the counter subsystem. Signed-off-by: James Roy <rruuaanng@outlook.com>
rruuaanng
force-pushed
the
dts-style-counter
branch
from
6c4eacf to
572de0a
Compare
kartben
approved these changes
Jan 13, 2025
nordic-krch
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the property names in the bindings and overlay to use hyphens(-) for separation instead of underscores(_).