boards: arm: mps2: Add initial FVP support for multiple mps2 boards #83697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Build System
area: GPIO
area: Sockets
zephyrbot
requested review from
57300,
henrikbrixandersen,
ithinuel,
jeremybettis,
jukkar,
katsuster,
martinjaeger,
mnkp,
nashif,
nordicjm,
pdgendt,
rlubos,
tbursztyka,
tejlmand and
wearyzen
|
There are typos in the commit message 247e4041a6b677fe463f6e4cf83e52933d8afc31
|
spchee
force-pushed
the
add_all_legacy_boards_final
branch
2 times, most recently
from
d299c24 to
9c4689a
Compare
|
Have just fixed the typo, thanks for noticing. |
nordicjm
requested changes
Jan 9, 2025
boards/arm/mps2/doc/mps2_v6m.rst
Outdated
| ############ | ||
|
|
||
| Overview | ||
| ******** | ||
|
|
||
| The mps2/an383 board configuration is used by Zephyr applications that run on |
There was a problem hiding this comment.
why are all these being renamed? Think this breaks board listing @kartben ?
There was a problem hiding this comment.
We originally tried to merge them into one, but there are too many differences to easily merge together into a single file. Hence the new boards are being grouped by architecture type since there is where any of the differences lie except the already existing an521 being kept separate. Have made a few changes to hopefully make it a bit clearer what is going on.
Added new mps2 soc an383 to enable testing with ARM FVP. Signed-off-by: Samuel Chee <samche01@arm.com>
spchee
force-pushed
the
add_all_legacy_boards_final
branch
from
9c4689a to
2f0ddcf
Compare
|
@nordicjm Thanks for the review, have pushed an updated version which should resolve all your comments. |
spchee
force-pushed
the
add_all_legacy_boards_final
branch
3 times, most recently
from
6a074f8 to
bbc7c06
Compare
nordicjm
reviewed
Jan 13, 2025
spchee
force-pushed
the
add_all_legacy_boards_final
branch
from
bbc7c06 to
7b05584
Compare
added 5 commits
January 14, 2025 16:24
Added new mps2 board an383 to enable testing with ARM FVP. Qualifier to build/run is mps2/an383 Signed-off-by: Samuel Chee <samche01@arm.com>
Added new mps2 soc an386 to enable testing with ARM FVP. Signed-off-by: Samuel Chee <samche01@arm.com>
Added a support for new mps2 board an386 to enable testing with ARM FVP. Qualifier to build/run application with board is mps2/an386. Signed-off-by: Samuel Chee <samche01@arm.com>
Adds fvp support for an385. Qualifier to build or run application with fvp is mps2/an385 Signed-off-by: Samuel Chee <samche01@arm.com>
Added new mps2 soc an383 to enable testing with ARM FVP. Signed-off-by: Samuel Chee <samche01@arm.com>
spchee
force-pushed
the
add_all_legacy_boards_final
branch
from
7b05584 to
85324ce
Compare
|
Thanks for the comments @nordicjm, most recent patch should have addressed everything |
Added support for an500 in fvp. Qualifier to build and run is mps2/an500. Signed-off-by: Samuel Chee <samche01@arm.com>
spchee
force-pushed
the
add_all_legacy_boards_final
branch
from
85324ce to
fb76f72
Compare
|
Have addressed your nits :) @nordicjm |
wearyzen
approved these changes
Jan 15, 2025
nordicjm
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mps2_base.dtsi