Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Add missing marshalling header for k_reschedule #83615

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thughes
Copy link

@thughes thughes commented Jan 7, 2025

Without this header, compiling the kernel.poll test with -Werror=unused-function fails.

Copy link

github-actions bot commented Jan 7, 2025

Hello @thughes, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... how is it not using the function? This should be followed by an include of the generated "...mrsh.c" marshalling code which references it (the marshalling function then gets stuffed into the global table of syscalls handlers).

I suspect the real problem is elsewhere. Did the include get forgotten?

@andyross
Copy link
Contributor

andyross commented Jan 7, 2025

Yeah, that seems like it. Just copy over the marshalling boilerplate from another function. This is a common goof; we'll add a syscalls and test coverage for it, but then forget to have coverage calling it from a userspace process.

@thughes thughes marked this pull request as draft January 8, 2025 22:03
Without this header, compiling the kernel.poll test with
-Werror=unused-function fails.

Signed-off-by: Tom Hughes <tomhughes@chromium.org>
@thughes thughes changed the title kernel: Add __maybe_unused to z_vrfy_k_reschedule kernel: Add missing marshalling header for k_reschedule Jan 8, 2025
@zephyrbot

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Kernel size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants