dts: ite: refactor the it8801 template hierarchy #83424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: RISCV
zephyrbot
requested review from
anangl,
brockus-zephyr,
Dino-Li,
fkokosinski,
gmarull,
GTLin08,
henrikbrixandersen,
jackrosenthal,
keith-zephyr,
kgugala,
mgielda,
mnkp,
RuibinChang,
sjg20 and
tgorochowik
fabiobaltieri
force-pushed
the
ite-template-refactor
branch
from
6883e4b to
0e5b82b
Compare
GTLin08
reviewed
Dec 30, 2024
| kso-mapping = <0 1 20 3 4 5 6 17 18 16 15 11 12>; | ||
| row-size = <8>; | ||
| col-size = <13>; | ||
| &ioex_it8801_kbd { |
There was a problem hiding this comment.
Nit: I accidentally left a space earlier.
There was a problem hiding this comment.
oh thank you, fixed
The it8801 template is helpful but in the current state it does not allow changing the device address as that is in the template itself. Fix that by moving the template content down a level in the hierarchy, so that it extends the mfd device itself rather than than instantiate it, then the base instance can have any address, now the only limitation is that only one instance is possible, but that is probably alright for now. Alternatives would be to use a define for the address, or even a template per address, but this feels like a better compromise for now. This may also use zephyrproject-rtos#82825 in the future if that ever becomes a thing. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
force-pushed
the
ite-template-refactor
branch
from
0e5b82b to
177b590
Compare
GTLin08
approved these changes
Dec 30, 2024
keith-zephyr
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The it8801 template is helpful but in the current state it does not allow changing the device address as that is in the template itself. Fix that by moving the template content down a level in the hierarchy, so that it extends the mfd device itself rather than than instantiate it, then the base instance can have any address, now the only limitation is that only one instance is possible, but that is probably alright for now.
Alternatives would be to use a define for the address, or even a template per address, but this feels like a better compromise for now. This may also use
#82825 in the future if that ever becomes a thing.