Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: application_development: Add spdx SBOM test #83359

Merged
merged 2 commits into from
Jan 15, 2025
Merged

tests: application_development: Add spdx SBOM test #83359

merged 2 commits into from
Jan 15, 2025

Conversation

pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented Dec 24, 2024 •
edited
Loading

Add a test where the software bill of materials is generated using the west spdx extension.

Depends on the CMake twister harness #83297.

@pdgendt pdgendt requested a review from hakehuang December 24, 2024 14:03
@pdgendt pdgendt force-pushed the tests-spdx branch 4 times, most recently from 91301b3 to 61f9515 Compare December 24, 2024 15:13
@pdgendt pdgendt mentioned this pull request Dec 24, 2024
Open
@pdgendt
scripts: west_command: spdx: Exit with non-zero code on failure
c182817 
If the init or the generation fails, the resulting exit code should be
non-zero.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@pdgendt
tests: application_development: Add spdx SBOM test
35b4ded 
Add a test where the software bill of materials is generated using the
west spdx extension.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@pdgendt pdgendt marked this pull request as ready for review January 10, 2025 07:28
@zephyrbot zephyrbot added the area: West West utility label Jan 10, 2025
@pdgendt pdgendt removed their assignment Jan 10, 2025
@pdgendt pdgendt requested a review from kartben January 10, 2025 07:40
hakehuang
hakehuang approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@hakehuang hakehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting test approach.

@pdgendt
Copy link
Collaborator Author

pdgendt commented Jan 13, 2025

interesting test approach.

It currently only verifies that west spdx runs with exit code 0. I'm not familiar with the expected output and how it could be validated.

henrikbrixandersen
henrikbrixandersen approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice starting point - and a good example of CMake test integration. Thanks!

@kartben kartben merged commit 5d23996 into zephyrproject-rtos:main Jan 15, 2025
44 checks passed
@pdgendt pdgendt deleted the tests-spdx branch January 15, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@hakehuang hakehuang hakehuang approved these changes

@kartben kartben kartben approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@mbolivar mbolivar Awaiting requested review from mbolivar

@swinslow swinslow Awaiting requested review from swinslow

Assignees
No one assigned
Labels
area: West West utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdgendt @kartben @hakehuang @henrikbrixandersen @zephyrbot