Bluetooth: Mesh: use settings priority feature #83214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Mesh
area: Bluetooth Host
zephyrbot
requested review from
akredalen,
alwa-nordic,
alxelax,
Andrewpini,
cvinayak,
HaavardRei,
hermabe,
jhedberg,
LingaoM,
omkar3141,
PavelVPV,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
|
Note: This PR is following up on the effort in #79690 |
|
Nit: Should the host changes be split into a separate commit? |
I'd assume its more clear looking back on this change as one commit instead of having separate commits. That said, I don't mind splitting it if that is the consensus of the reviewers. |
PavelVPV
requested changes
Dec 20, 2024
KyraLengfeld
force-pushed
the
use_settings_prio_feature_mesh_start
branch
from
0e463af to
cf53f1b
Compare
zephyrbot
added
area: Bluetooth Classic
KyraLengfeld
commented
Dec 21, 2024
KyraLengfeld
force-pushed
the
use_settings_prio_feature_mesh_start
branch
from
cf53f1b to
9c1f3d0
Compare
alxelax
requested changes
Jan 2, 2025
By using `SETTINGS_STATIC_HANDLER_DEFINE_WITH_CPRIO` we can ensure that BT subsystems always get loaded after BT, and BT Mesh after both of them. This solves the host having to register a GATT service in a delayed manner, as we are sure to now register the GATT service after sc_commit sets `SC_LOAD`. Signed-off-by: Kyra Lengfeld <kyra.lengfeld@nordicsemi.no>
KyraLengfeld
force-pushed
the
use_settings_prio_feature_mesh_start
branch
from
9c1f3d0 to
8149a93
Compare
alxelax
approved these changes
Jan 3, 2025
PavelVPV
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
SETTINGS_STATIC_HANDLER_DEFINE_WITH_CPRIOwe can ensure that BT subsystems always get loaded after BT, and BT Mesh after both of them.This solves the host having to register a GATT service in a delayed manner, as we are sure to now register the GATT service after sc_commit sets
SC_LOAD.