STM32WB0: add TRNG support #83152
Merged
STM32WB0: add TRNG support #83152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuchopstm
force-pushed
the
wb0x_rng
branch
from
659c1e3 to
c7a87e3
Compare
|
erwango
requested changes
Jan 9, 2025
drivers/entropy/entropy_stm32.c
Outdated
| @@ -124,6 +140,68 @@ static struct entropy_stm32_rng_dev_data entropy_stm32_rng_data = { | |||
| .rng = (RNG_TypeDef *)DT_INST_REG_ADDR(0), | |||
| }; | |||
|
|
|||
| /* Cross-series LL compatibility wrappers */ | |||
| static inline void ll_rng_EnableIT(RNG_TypeDef *RNGx) | |||
There was a problem hiding this comment.
Let's use rather: ll_rng_enable_it
drivers/entropy/entropy_stm32.c
Outdated
| @@ -124,6 +140,68 @@ static struct entropy_stm32_rng_dev_data entropy_stm32_rng_data = { | |||
| .rng = (RNG_TypeDef *)DT_INST_REG_ADDR(0), | |||
| }; | |||
|
|
|||
| /* Cross-series LL compatibility wrappers */ | |||
There was a problem hiding this comment.
Please move wrappers in a header file
drivers/entropy/entropy_stm32.c
Outdated
Comment on lines
39
to
44
| #else /* DT_INST_NUM_IRQS(0) == 0 */ | ||
| /* DT_PROP_OR is used to remove noise from error message */ | ||
| BUILD_ASSERT(DT_INST_NODE_HAS_PROP(0, generation_delay_ns), | ||
| "RNG '" DT_NODE_FULL_NAME(DT_DRV_INST(0)) "' has no interrupt line " | ||
| "but lacks the mandatory 'generation-delay-ns' property"); | ||
| #define TRNG_GENERATION_DELAY K_NSEC(DT_INST_PROP_OR(0, generation_delay_ns, 0)) |
There was a problem hiding this comment.
Please modify bindings so they can catch this issue and get rid of this
Add a new binding for STM32 RNG instances without interrupt lines, such as the one present in the STM32WB05/06/07 SoCs. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
Add Device Tree nodes corresponding to TRNG of STM32WB0 series SoCs. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
mathieuchopstm
force-pushed
the
wb0x_rng
branch
from
c7a87e3 to
256023f
Compare
zephyrbot
requested review from
ceolin,
djiatsaf-st,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st and
tomi-font
Add support for TRNG peripherals that lack interrupt lines in the STM32 entropy driver. This enables usage of the TRNG of STM32WB05/06/07 SoCs with the driver. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
Add overlay to allow testing of RNG driver on STM32WB0 hardware. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
mathieuchopstm
force-pushed
the
wb0x_rng
branch
from
256023f to
d06bee5
Compare
erwango
reviewed
Jan 13, 2025
drivers/entropy/entropy_stm32.h
Outdated
Comment on lines
32
to
37
| #if defined(CONFIG_SOC_STM32WB09XX) | ||
| LL_RNG_EnableEnErrorIrq(RNGx); | ||
| LL_RNG_EnableEnFfFullIrq(RNGx); | ||
| #else /* !CONFIG_SOC_SERIES_STM32WB0X */ | ||
| LL_RNG_EnableIT(RNGx); | ||
| #endif /* CONFIG_SOC_SERIES_STM32WB0X */ |
There was a problem hiding this comment.
Please use consistent style in the file.
Add support for the STM32WB09-specific TRNG IP in STM32 entropy driver. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
Add overlay to allow testing of RNG driver on STM32WB0 hardware. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
Add overlay to allow testing of TRNG on STM32WB07. Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
mathieuchopstm
force-pushed
the
wb0x_rng
branch
from
d06bee5 to
636fd1d
Compare
erwango
approved these changes
Jan 13, 2025
djiatsaf-st
approved these changes
Jan 17, 2025
tomi-font
approved these changes
Jan 21, 2025
| * This node is valid for STM32WB05, STM32WB06 and | ||
| * STM32WB07, all equipped with the same IRQ-less | ||
| * TRNG instance. Since all those properties are | ||
| * also valid on STM32SWB09, except "compatible", |
There was a problem hiding this comment.
Suggested change
| * also valid on STM32SWB09, except "compatible", | |
| * also valid on STM32SWB09 except "compatible", |
|
@ceolin PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for TRNG of STM32WB0 series to existing STM32 driver. Test overlay for Nucleo-WB05KZ and Nucleo-WB09KE is also added so that correct behavior can be verified.
Tested OK using standard
tests/drivers/entropy/apiand modified version that also verifies entropy_get_entropy_from_isr and large buffer sizes. Also tested on Nucleo-WB07CC, but board is not upstream yet.Potentially supersedes #83109 - driver modification is split in two commits and PR is marked as draft for this reason.