-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: wifi: winc1500: Driver fixes #80897
base: main
Are you sure you want to change the base?
Conversation
fb26007
to
35f213e
Compare
…set. The "nm_bsp_reset" is used to apply a hard reset to the WINC board by setting CHIP_EN and RESET_N signals low,then after specific delay the function will put CHIP_EN high then RESET_N high. reset-gpio is however defined as active low , causing this function to hold the wifi module in reset. Signed-off-by: Andreas Ålgård <aal@ixys.no>
When we accept a message the context state should be set to connected Signed-off-by: Andreas Ålgård <aal@ixys.no>
Renamed socket functions to avoid multiple definitions in the HAL library Signed-off-by: Andreas Ålgård <aal@ixys.no>
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Hi @icsys-aal ,
Changes LGTM but we need to tests with https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/net/wifi/apsta_mode sample. Could you check this? |
I tried to test this, but failed as the dhcpv4 server init function failed, which I suspect is because WINC1500 has its own DHCP server when it is in AP mode. |
That is correct, it was relocated from esp32 driver sample by commit d75b210 |
Hi @jukkar , It has been sometime I'm not looking this area. My expectation is that at least the shield could work as mentioned here https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/shields/adafruit_winc1500/doc/index.rst |
Yes, that is correct. |
Hi @jukkar ,
Thank you for clarify : ) Sorry for my confusion with the wrong sample. In the past the driver seems to worked with the samples/net/wifi/shell. Could you check https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/shields/adafruit_winc1500/doc/index.rst and see if we can have a valid config ? I would like understand how are you testing the WINC1500. Is there any application in tree that I can reproduce ? What is the configuration ? My intention is detect any problem with the recent version of this driver in Zephyr and have an issue that point this. It is very valuable your input here since you know how it works. If you can report here I'll rely appreciate. |
@icsys-aal This has been pending for a long time, any plans to push this forward? |
Hello, I apologize for not getting back to you sooner. However, in our application we use the WINC1500 driver in AP mode, and this has exposed additional issues, so we'll try to make a subsequent PR with additional fixes, once we've verified them. |
Needed for the winc1500 driver in hal_atmel to be compatible with POSIX enabled. Signed-off-by: Andreas Ålgård <aal@ixys.no>
We're using the WINC1500 driver in an application where we want our board to be an access point. This has exposed several issues with the current WINC1500 driver, which this PR tries to fix.
Note that we haven't tested client mode with these changes.