scripts: ci: check_compliancy: Add zephyr-keep-sorted regex support #80444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Continuous Integration
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
nashif,
simhein and
stephanosio
pdgendt
force-pushed
the
keep-sorted-regex
branch
2 times, most recently
from
5f8658d to
9ce9268
Compare
pdgendt
commented
Oct 25, 2024
pdgendt
force-pushed
the
keep-sorted-regex
branch
from
9ce9268 to
285bf21
Compare
pdgendt
force-pushed
the
keep-sorted-regex
branch
from
285bf21 to
41c87e9
Compare
To support checking for sorted blocks of multi-line text add an optional regex pattern for the KeepSorted compliance check. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Keep the UNDEF_KCONFIG_ALLOWLIST list sorted, as mentioned in the comment. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt
force-pushed
the
keep-sorted-regex
branch
from
41c87e9 to
7143c2b
Compare
|
Hey @pdgendt, wasn't the foldback feature enough to cover milti-line text? I'm happy with the feature if we need it but I can't quite wrap my head around why it was not working before and would rather keep the simpler code base if possible |
|
It won't work for example for #79754, but there are probably more cases in tree that could benefit from this IMO. |
Oh because the closing bracket is not folded back? |
Yes |
fabiobaltieri
approved these changes
Oct 30, 2024
keith-zephyr
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support checking for sorted blocks of multi-line text add an optional regex pattern for the KeepSorted compliance check.