Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32wba: Update of west blobs fetch command due to field name definition in hal_stm32 module.yml #77611

Merged
merged 2 commits into from
Aug 29, 2024
Merged

stm32wba: Update of west blobs fetch command due to field name definition in hal_stm32 module.yml #77611

merged 2 commits into from
Aug 29, 2024

Conversation

erwango
Copy link
Member

@erwango erwango commented Aug 27, 2024 •
edited by jhedberg
Loading

stm32wba: Update of west blobs fetch command due to field name definition in hal_stm32 module.yml

@zephyrbot zephyrbot added Release Notes To be mentioned in the release notes platform: STM32 ST Micro STM32 labels Aug 27, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 27, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@484af4f zephyrproject-rtos/hal_stm32@4c1adf8 (main) zephyrproject-rtos/hal_stm32@484af4f9..4c1adf8a

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_stm32 DNM This PR should not be merged (Do Not Merge) labels Aug 27, 2024
@mathieuchopstm mathieuchopstm changed the title stm32wba: Update of west blobs fecth command due to field name definition in hal_stm32 module.yml stm32wba: Update of west blobs fetch command due to field name definition in hal_stm32 module.yml Aug 27, 2024
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Aug 27, 2024
dkalowsk
dkalowsk previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, minor question if this needs to also be added to the 4.0 release notes or if the migration guide is enough.

@jhedberg jhedberg mentioned this pull request Aug 27, 2024
Merged
@jhedberg
Copy link
Member

@erwango looks like you need to rebase

erwango added 2 commits August 28, 2024 09:05
@erwango
west.yml: hal_stm32: Add name to module.yml
449583a 
hal_stm32 was missing a `name` in module.yml
Point to the module version where this is fixed.

Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
@erwango
boards: nucleo_wba55cg: Update blob fetch command
5ad0860 
Following addition of a `name` to hal_stm32 module, the command to fetch
blobs that are required to build BLE applications on STM32WBA socs is now
changed from `west blob fetch stm32` to `west blob fetch hal_stm32`.
Update documentation and warn users in migration guide.

Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
@erwango
Copy link
Member Author

erwango commented Aug 28, 2024

Changes look fine, minor question if this needs to also be added to the 4.0 release notes or if the migration guide is enough.

Good question.
This change is quite limited and doesn't bring much value a part compliance. Though, it will impact the existing wba blob users which will get the info in the migration guide.
In release notes, I'd rather mention new features or changes which bring additional value to users... So not this change.

@erwango erwango requested a review from dkalowsk August 28, 2024 07:40
@carlescufi carlescufi merged commit 40e1b89 into zephyrproject-rtos:main Aug 29, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieuchopstm mathieuchopstm mathieuchopstm approved these changes

@gautierg-st gautierg-st gautierg-st approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@jhedberg jhedberg jhedberg approved these changes

@FRASTM FRASTM Awaiting requested review from FRASTM

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@kartben kartben Awaiting requested review from kartben

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

Assignees

@dkalowsk dkalowsk

@mmahadevan108 mmahadevan108

Labels
manifest manifest-hal_stm32 platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@erwango @zephyrbot @jhedberg @dkalowsk @mmahadevan108 @gautierg-st @mathieuchopstm @carlescufi