gnss: rename u-blox M10 driver to M8 #76401
Conversation
zephyrbot
added
area: GNSS
Release Notes
zephyrbot
requested review from
aescolar,
bjarki-andreasen,
decsny,
fabiobaltieri,
galak,
kartben,
nashif and
tomi-font
There was a problem hiding this comment.
Could you make it so that this file also shows up as moved instead of added?
There was a problem hiding this comment.
I'm pretty sure that would involve patching git...
Its not showing up as moved because basically every line has been changed, but I can't do anything about that without leaving the defines with the incorrect names.
There was a problem hiding this comment.
Okay, yeah I do bump into this limitation of git when renaming and modifying a file in a same commit. Kinda sucks. I was wondering here cause you managed to have it show up properly for other files.
JordanYates
force-pushed
the
240729_ublox_m8
branch
from
5ed60ad to
4e62624
Compare
Can't be done until the templates for 4.0 are added |
@kartben maybe? |
|
Nice catch! I can't find any documentation from NXP actually stating the GNSS modem variant, their schematic just says |
|
Merged, was holding few patches back. |
JordanYates
force-pushed
the
240729_ublox_m8
branch
from
4e62624 to
a7af632
Compare
JordanYates
force-pushed
the
240729_ublox_m8
branch
from
a7af632 to
db1c474
Compare
| @@ -861,7 +861,7 @@ Drivers and Sensors | |||
|
|
|||
| * Added GNSS device driver API test suite. | |||
| * Added support for the u-blox UBX protocol. | |||
| * Added device driver for the u-blox M10 GNSS modem (:dtcompatible:`u-blox,m10`). | |||
| * Added device driver for the u-blox M8 GNSS modem (:dtcompatible:`u-blox,m8`). | |||
There was a problem hiding this comment.
It's nice to fix the 3.7 release notes, but there the DT compatible (and driver name) will still be M10. Unless this is backported?
There was a problem hiding this comment.
I'm not sure that this is worthy of backporting, it is not a bug or a security vulnerability, just a name correction.
The choice is either leave the old release notes alone, and the link will be dead, or I can update the old notes and have the name be inconsistent.
Neither is ideal.
The driver in tree is for u-blox M8 devices, not M10. The M10 series devices (from Protocol Version 23.01) use a different, non backwards compatible interface for configuring the modem behaviour. Of the two boards tested in the original PR, the "VMU RT1170" is explicitly listed as having a u-blox NEO-M8N modem, while I have been unable to find any information online about the "FMURT6" board. Leaving the naming as-is will cause problems when M10 drivers are contributed. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
dismissed stale reviews from fabiobaltieri, bjarki-andreasen, and tomi-font
via
89c9678
JordanYates
force-pushed
the
240729_ublox_m8
branch
from
db1c474 to
89c9678
Compare
The driver in tree is for u-blox M8 devices, not M10. The M10 series devices (from Protocol Version 23.01) use a different, non backwards compatible interface for configuring the modem behaviour.
Of the two boards tested in the original PR, the "VMU RT1170" is explicitly listed as having a u-blox NEO-M8N modem, while I have been unable to find any information online about the "FMURT6" board.
Leaving the naming as-is will cause problems when M10 drivers are contributed.
Original PR: #68350