drivers: ethernet: stm32: fix PTP on STM32F7 #75085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of recent update of stm32f7 HAL to cube version V1.17.2 the workaround for misspelled HAL_ETH_PTP_CONFIGURATED macro is not needed anymore, and causes PTP support to fail to compile. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
zephyrbot
added
platform: STM32
zephyrbot
requested review from
ajarmouni-st,
decsny,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
lmajewski,
marwaiehm-st and
pdgendt
erwango
approved these changes
Jun 27, 2024
jukkar
approved these changes
Jun 27, 2024
|
@erwango There is more needed to fix PTP on F7 - I just opened zephyrproject-rtos/hal_stm32#220 |
FRASTM
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of recent update of stm32f7 HAL to cube version V1.17.2 the workaround for misspelled
HAL_ETH_PTP_CONFIGURATEDmacro is not needed anymore, and causes PTP support to fail to compile.See https://github.com/zephyrproject-rtos/hal_stm32/blame/855f195793df094644ce8b8617c01275408bbf58/stm32cube/stm32f7xx/drivers/include/stm32f7xx_hal_eth.h#L1696
cc @marwaiehm-st