Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sensors: Add driver for LM95234 temperature sensor #71169

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

robhancocksed
Copy link
Contributor

Add a driver for the National/TI LM95234 Quad Remote Diode and Local Temperature Sensor with SMBus Interface and TruTherm Technology.

@zephyrbot zephyrbot requested a review from decsny May 2, 2024 15:09
@decsny decsny removed their request for review May 2, 2024 16:56
@robhancocksed robhancocksed force-pushed the add-lm95234-driver branch 2 times, most recently from d4c2196 to 63ccabd Compare May 9, 2024 17:49
@robhancocksed
Copy link
Contributor Author

Rebased to main to fix a conflict. @jeppenodgaard I think your comments are all addressed?

@jeppenodgaard
Copy link
Collaborator

Rebased to main to fix a conflict. @jeppenodgaard I think your comments are all addressed?

Yes. LGTM. There is no resolve buttons for some reason.

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, but otherwise LGTM

@robhancocksed
Copy link
Contributor Author

A couple nits, but otherwise LGTM

Updated as suggested.

MaureenHelm
MaureenHelm previously approved these changes May 13, 2024
@robhancocksed
Copy link
Contributor Author

Ping - any additional comments?

teburd
teburd previously approved these changes Jun 12, 2024
Add a driver for the National/TI LM95234 Quad Remote Diode and Local
Temperature Sensor with SMBus Interface and TruTherm Technology.

Signed-off-by: Robert Hancock <robert.hancock@calian.com>
@robhancocksed robhancocksed dismissed stale reviews from teburd and MaureenHelm via c8e46cc June 12, 2024 16:45
@zephyrbot zephyrbot requested a review from ubieda June 12, 2024 16:46
@robhancocksed
Copy link
Contributor Author

Fixed conflicts in the tests/drivers/build_all/sensor/i2c.dtsi file, no other changes from last rev.

@aescolar aescolar merged commit 2d171ef into zephyrproject-rtos:main Jun 14, 2024
22 checks passed
@robhancocksed robhancocksed deleted the add-lm95234-driver branch June 14, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants