drivers: esp32: SDHC implementation #71165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
de-nordic,
galak,
gmarull,
kartben,
Laczen,
LucasTambor,
marekmatej,
nashif and
uLipe
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
raffarost
force-pushed
the
feature/sdhc
branch
4 times, most recently
from
f47fb71 to
d9fdeab
Compare
There was a problem hiding this comment.
General comment- please avoid using static global variables in this driver, unless the variable can be shared across multiple instances. For example, it seems one HAL context structure would need to be allocated per device instance, so that structure should be defined in a device data structure
raffarost
force-pushed
the
feature/sdhc
branch
2 times, most recently
from
3cb2ed3 to
e90c96a
Compare
raffarost
force-pushed
the
feature/sdhc
branch
2 times, most recently
from
ffdebde to
ab54a1f
Compare
hal_espressif update for SDHC driver support Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
raffarost
force-pushed
the
feature/sdhc
branch
3 times, most recently
from
3e2802f to
d239364
Compare
danieldegrasse
previously approved these changes
Apr 26, 2024
added 3 commits
April 26, 2024 11:28
Implementation of SDHC driver for ESP32 Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
Configuration files to enable SDHC in esp_wrover_kit Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
Alias created for sdhc0 SPI device to avoid conflict with SDIO device names. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
sylvioalves
approved these changes
Apr 26, 2024
marekmatej
approved these changes
Apr 26, 2024
danieldegrasse
approved these changes
Apr 30, 2024
|
Hei, I'm seeing error about |
sylvioalves
added a commit
to sylvioalves/zephyr
that referenced
this pull request
May 1, 2024
Update revision reference for PR zephyrproject-rtos#71165 as needed. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
fabiobaltieri
pushed a commit
that referenced
this pull request
May 2, 2024
Update revision reference for PR #71165 as needed. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
mariopaja
pushed a commit
to mariopaja/zephyr
that referenced
this pull request
May 26, 2024
Update revision reference for PR zephyrproject-rtos#71165 as needed. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32 support for SD cards using SDIO interface