drivers/counter nrfx: Fix with DT instance not matching device instance #69966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
reviewed
Mar 8, 2024
gmarull
reviewed
Mar 8, 2024
aescolar
force-pushed
the
nrfbsim_counter_driver_fix
branch
from
0abc5f1 to
9477bba
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
gmarull
previously approved these changes
Mar 8, 2024
anangl
previously approved these changes
Mar 8, 2024
nordic-krch
previously approved these changes
Mar 8, 2024
* Update the HW models module to 3925b7030736f25f45ceedc3621219125a2d4685 Including the following: * 3925b70: Add new API to convert real peripheral addr to simulated one * 319e3eb: nhw_convert_periph_base_addr: Fix include for nrf5340 Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
478530e introduced a bug where if the DT index while iterating its DT structure initialization does not match the actual peripheral instance, or if the device instance string is not just a simple integer, but a more complex string like "00", or "02", either the wrong peripheral address would be used, or the file would failt to compile. Let's fix this by reverting that change, and instead, for simulation converting the hardcoded DT/real HW address to the valid addr for simulation on the fly. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
dismissed stale reviews from nordic-krch, anangl, and gmarull
via
af4f022
aescolar
force-pushed
the
nrfbsim_counter_driver_fix
branch
from
b1fdfd0 to
af4f022
Compare
nordic-krch
approved these changes
Mar 8, 2024
anangl
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
478530e introduced a bug where if the DT index while iterating its DT structure initialization does not match the actual peripheral instance, or if the device instance string is not just a simple integer, but a more complex string like "00", or "02", either the wrong peripheral address would be used, or the file would failt to compile.
Let's fix this by reverting that change, and instead, for simulation converting the hardcoded DT/real HW address to the valid addr for simulation on the fly.
Fixes #69216