Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: convert ARCH_DIR path to CMake style #68719

Closed
wants to merge 1 commit into from
Closed

cmake: convert ARCH_DIR path to CMake style #68719

wants to merge 1 commit into from

Conversation

dleach02
Copy link
Member

@dleach02 dleach02 commented Feb 7, 2024

Windows build needs this when generating offsets.c

@dleach02
Copy link
Member Author

dleach02 commented Feb 7, 2024

@tejlmand, I needed to do this fix for Windows builds. But to be honest, not sure if there isn't a better place for this.

@dleach02 dleach02 requested review from tejlmand and nordicjm February 8, 2024 00:09
@tejlmand
Copy link
Collaborator

tejlmand commented Feb 8, 2024

@tejlmand, I needed to do this fix for Windows builds. But to be honest, not sure if there isn't a better place for this.

if this is needed here, then it's a more fundamental problem and we should ensure that ARCH_DIR is correct from the start.
Probably the reason for the change is that we have switched from determine arch dir based on folder (in CMake) to use python, and thus python might give us a native path, not a posix path.

Will take a look, thanks for finding this.

Windows build needs this when generating offsets.c

Signed-off-by: David Leach <david.leach@nxp.com>
@tejlmand
Copy link
Collaborator

please take a look here: #69023

@tejlmand
Copy link
Collaborator

Closing as #69023 has been merged.

@tejlmand tejlmand closed this Feb 20, 2024
@dleach02 dleach02 deleted the fix_collab_windows1 branch July 17, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants