boards: mps2_an521: Fix qemu error on Windows #68661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butok
previously approved these changes
Feb 9, 2024
ithinuel
reviewed
Mar 5, 2024
pty is not available on Windows hosts. Running a sample in Qemu on Windows shows an error. Fix it by enabling pty on Unix hosts only. Signed-off-by: Michal Smola <michal.smola@nxp.com>
michal-smola
force-pushed
the
fix_mps2_an521_ns_windows
branch
from
bb7da1a to
9fc7f1d
Compare
|
The line creates a new pseudo-terminal on the host, connects to it, and redirects the virtual serial port to pseudo-terminal Pseudo-terminal is now available on Windows, it causes QEMU error on Windows. |
butok
approved these changes
Mar 5, 2024
|
I understand, thank you. |
nashif
approved these changes
Mar 5, 2024
|
@ithinuel QEMU prints output from serial on Windows, because QEMU still uses options -chardev stdio,id=con,mux=on -serial chardev:con, to connect serial to standard input and output of the QEMU process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QEMU for mps2_an521 uses tty and pty which is not available on Windows hosts. Running a sample in QEMU on Windows shows an error. Fix it by enabling tty on Unix hosts only.