storeage/stream_flash: Cache write_block_size to ctx on init #68658
Conversation
de-nordic
force-pushed
the
stream_flash_sync_wbs
branch
from
9c676bb to
f9d4c77
Compare
The commit caches write_block_size and erase_value to stream flash context, at init, to avoid calling Flash API multiple times to get these values at various stages of code exectuion, at run-time. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
stream_flash_sync_wbs
branch
from
f9d4c77 to
1a23b32
Compare
| @@ -65,6 +65,8 @@ struct stream_flash_ctx { | |||
| #ifdef CONFIG_STREAM_FLASH_ERASE | |||
| off_t last_erased_page_start_offset; /* Last erased offset */ | |||
| #endif | |||
| uint8_t erase_value; | |||
| uint8_t write_block_size; /* Offset/size device write alignment */ | |||
There was a problem hiding this comment.
@de-nordic I have now updated to Zephyr 3.7 and this is a bug for me.
The block size on the device I'm using, NXP's LPC55S59, is 512 and of course, we have an issue since this was defined as 1 byte (max size is 255).
This needs to be size_t.
How should we proceed here?
There was a problem hiding this comment.
Hi. I have provided fix here #76053.
Thanks for reporting the issue.
I just want to mention that you are always free to provide a fix that will go under review, so any doubts you can have, regarding technical solution, can be resolved together in the context of your contribution; so next time you find something like this I would like to encourage you to log an issue and, if you have time, follow it with a fix.
The commit caches write_block_size and erase_value to stream flash context, at init, to avoid calling Flash API multiple times to get these values at various stages of code exectuion, at run-time.